github-actions[bot] commented on code in PR #27829:
URL: https://github.com/apache/doris/pull/27829#discussion_r1415400020
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -1055,23 +1067,50 @@ void FragmentMgr::cancel_instance_unlocked(const
TUniqueId& instance_id,
}
}
+void FragmentMgr::cancel_fragment(const TUniqueId& query_id, int32_t
fragment_id,
+ const PPlanFragmentCancelReason& reason,
const std::string& msg) {
+ std::unique_lock<std::mutex> state_lock(_lock);
+ return cancel_fragment_unlocked(query_id, fragment_id, reason, state_lock,
msg);
+}
+
+void FragmentMgr::cancel_fragment_unlocked(const TUniqueId& query_id, int32_t
fragment_id,
Review Comment:
warning: method 'cancel_fragment_unlocked' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void FragmentMgr::cancel_fragment_unlocked(const TUniqueId& query_id,
int32_t fragment_id,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
