morrySnow commented on code in PR #28026:
URL: https://github.com/apache/doris/pull/28026#discussion_r1415371410


##########
fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java:
##########
@@ -240,6 +251,8 @@ public abstract class Type {
         structSubTypes.add(DECIMAL32); // same DEFAULT_DECIMALV3
         structSubTypes.add(DECIMAL64);
         structSubTypes.add(DECIMAL128);

Review Comment:
   decimal256?



##########
fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java:
##########
@@ -249,6 +262,10 @@ public abstract class Type {
         structSubTypes.add(CHAR);
         structSubTypes.add(VARCHAR);
         structSubTypes.add(STRING);
+        structSubTypes.add(NULL);
+        structSubTypes.add(ARRAY);
+        structSubTypes.add(MAP);
+        structSubTypes.add(STRUCT);

Review Comment:
   do we support variant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to