github-actions[bot] commented on code in PR #27886: URL: https://github.com/apache/doris/pull/27886#discussion_r1415336854
########## be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp: ########## @@ -634,16 +639,17 @@ Status PipelineXFragmentContext::_create_tree_helper(ObjectPool* pool, return Status::OK(); } -Status PipelineXFragmentContext::_add_local_exchange(int idx, int node_id, ObjectPool* pool, - PipelinePtr cur_pipe, - const std::vector<TExpr>& texprs, - ExchangeType exchange_type, - bool* do_local_exchange) { +Status PipelineXFragmentContext::_add_local_exchange( Review Comment: warning: function '_add_local_exchange' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp Status PipelineXFragmentContext::_add_local_exchange( ^ ``` <details> <summary>Additional context</summary> **be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:641:** 99 lines including whitespace and comments (threshold 80) ```cpp Status PipelineXFragmentContext::_add_local_exchange( ^ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org