wuwenchi commented on code in PR #161:
URL: 
https://github.com/apache/doris-spark-connector/pull/161#discussion_r1414814895


##########
spark-doris-connector/src/main/java/org/apache/doris/spark/load/RecordBatch.java:
##########
@@ -58,21 +62,29 @@ public class RecordBatch {
 
     private final boolean addDoubleQuotes;
 
-    private RecordBatch(Iterator<InternalRow> iterator, String format, String 
sep, byte[] delim,
+    private VectorSchemaRoot arrowRoot = null;
+
+    private int arrowBatchSize = 1000;

Review Comment:
   This is the number obtained after comparing the performance of arrows when 
testing the performance.
   However, there may be other scenarios, and perhaps a configuration item can 
be added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to