morrySnow commented on code in PR #27944:
URL: https://github.com/apache/doris/pull/27944#discussion_r1413490575


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/TableIf.java:
##########
@@ -236,6 +236,34 @@ default void addForeignConstraint(String name, 
ImmutableList<String> columns,
         }
     }
 
+    default void dropConstraint(String name) {
+        writeLock();
+        try {
+            Map<String, Constraint> constraintMap = getConstraintsMap();
+            if (constraintMap.containsKey(name)) {

Review Comment:
   i think it is better to throw exception when constraint not exists?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to