github-actions[bot] commented on code in PR #26709:
URL: https://github.com/apache/doris/pull/26709#discussion_r1413010093
##########
be/src/vec/data_types/serde/data_type_datev2_serde.cpp:
##########
@@ -101,7 +101,7 @@ void DataTypeDateV2SerDe::read_column_from_arrow(IColumn&
column, const arrow::A
int start, int end,
const cctz::time_zone& ctz)
const {
auto& col_data = static_cast<ColumnVector<UInt32>&>(column).get_data();
- auto concrete_array = dynamic_cast<const arrow::Date64Array*>(arrow_array);
+ auto concrete_array = dynamic_cast<const arrow::Date32Array*>(arrow_array);
Review Comment:
warning: 'auto concrete_array' can be declared as 'const auto
*concrete_array' [readability-qualified-auto]
```suggestion
const auto *concrete_array = dynamic_cast<const
arrow::Date32Array*>(arrow_array);
```
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -110,6 +118,52 @@
}
}
+void DataTypeDateTimeV2SerDe::read_column_from_arrow(IColumn& column,
+ const arrow::Array*
arrow_array, int start,
+ int end, const
cctz::time_zone& ctz) const {
+ auto& col_data = static_cast<ColumnVector<Int64>&>(column).get_data();
+ int64_t divisor = 1;
+ if (arrow_array->type()->id() == arrow::Type::TIMESTAMP) {
+ auto concrete_array = dynamic_cast<const
arrow::TimestampArray*>(arrow_array);
Review Comment:
warning: 'auto concrete_array' can be declared as 'const auto
*concrete_array' [readability-qualified-auto]
```suggestion
const auto *concrete_array = dynamic_cast<const
arrow::TimestampArray*>(arrow_array);
```
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -110,6 +118,52 @@ void DataTypeDateTimeV2SerDe::write_column_to_arrow(const
IColumn& column, const
}
}
+void DataTypeDateTimeV2SerDe::read_column_from_arrow(IColumn& column,
Review Comment:
warning: method 'read_column_from_arrow' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:122:
```diff
- int end, const
cctz::time_zone& ctz) const {
+ int end, const
cctz::time_zone& ctz) {
```
be/src/vec/data_types/serde/data_type_datetimev2_serde.h:64:
```diff
- void read_column_from_arrow(IColumn& column, const arrow::Array*
arrow_array, int start,
- int end, const cctz::time_zone& ctz) const
override;
+ static void read_column_from_arrow(IColumn& column, const
arrow::Array* arrow_array, int start,
+ int end, const cctz::time_zone& ctz)
override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
