yiguolei commented on code in PR #27831:
URL: https://github.com/apache/doris/pull/27831#discussion_r1412744471


##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##########
@@ -75,9 +76,65 @@ public class WorkloadGroupMgr implements Writable, 
GsonPostProcessable {
     @SerializedName(value = "idToWorkloadGroup")
     private final Map<Long, WorkloadGroup> idToWorkloadGroup = 
Maps.newHashMap();
     private final Map<String, WorkloadGroup> nameToWorkloadGroup = 
Maps.newHashMap();
+    private final Map<Long, QueryQueue> idToQueryQueue = Maps.newHashMap();
     private final ResourceProcNode procNode = new ResourceProcNode();
     private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
 
+    private Thread updatePropThread;
+    private volatile boolean stopped = false;
+
+    public void stopUpdateThread() {

Review Comment:
   stop never called?



##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##########
@@ -75,9 +76,65 @@ public class WorkloadGroupMgr implements Writable, 
GsonPostProcessable {
     @SerializedName(value = "idToWorkloadGroup")
     private final Map<Long, WorkloadGroup> idToWorkloadGroup = 
Maps.newHashMap();
     private final Map<String, WorkloadGroup> nameToWorkloadGroup = 
Maps.newHashMap();
+    private final Map<Long, QueryQueue> idToQueryQueue = Maps.newHashMap();
     private final ResourceProcNode procNode = new ResourceProcNode();
     private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
 
+    private Thread updatePropThread;
+    private volatile boolean stopped = false;
+
+    public void stopUpdateThread() {

Review Comment:
   stop never called?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to