JNSimba commented on code in PR #166:
URL:
https://github.com/apache/doris-spark-connector/pull/166#discussion_r1411803845
##########
spark-doris-connector/src/main/java/org/apache/doris/spark/util/DataUtil.java:
##########
@@ -29,43 +31,31 @@
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.Map;
+import java.util.Objects;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+import java.util.stream.Stream;
public class DataUtil {
private static final ObjectMapper MAPPER =
JsonMapper.builder().addModule(new DefaultScalaModule()).build();
public static final String NULL_VALUE = "\\N";
- public static byte[] rowToCsvBytes(InternalRow row, StructType schema,
String sep) {
- StringBuilder builder = new StringBuilder();
+ public static byte[] rowToCsvBytes(InternalRow row, StructType schema,
String sep, boolean quote) {
Review Comment:
It might be better to add a unit test to this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
