github-actions[bot] commented on code in PR #26856:
URL: https://github.com/apache/doris/pull/26856#discussion_r1411564553
##########
be/src/http/action/stream_load.cpp:
##########
@@ -187,8 +187,12 @@ int StreamLoadAction::on_header(HttpRequest* req) {
url_decode(req->param(HTTP_TABLE_KEY), &ctx->table);
ctx->label = req->header(HTTP_LABEL_KEY);
Status st = Status::OK();
- if (iequal(req->header(HTTP_GROUP_COMMIT), "true") ||
- config::wait_internal_group_commit_finish) {
+ ctx->two_phase_commit = req->header(HTTP_TWO_PHASE_COMMIT) == "true" ?
true : false;
Review Comment:
warning: redundant boolean literal in ternary expression result
[readability-simplify-boolean-expr]
```suggestion
ctx->two_phase_commit = req->header(HTTP_TWO_PHASE_COMMIT) == "true";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
