yiguolei commented on code in PR #27749:
URL: https://github.com/apache/doris/pull/27749#discussion_r1410706684


##########
be/src/vec/runtime/vdata_stream_recvr.cpp:
##########
@@ -427,11 +428,13 @@ Status VDataStreamRecvr::create_merger(const 
VExprContextSPtrs& ordering_expr,
 Status VDataStreamRecvr::add_block(const PBlock& pblock, int sender_id, int 
be_number,
                                    int64_t packet_seq, 
::google::protobuf::Closure** done) {
     SCOPED_ATTACH_TASK_WITH_ID(_query_mem_tracker, _query_id, 
_fragment_instance_id);
+    _mem_tracker->consume(pblock.ByteSizeLong());

Review Comment:
   do not consume PB object's size, because you do not rellease its size.
   And I think it is useless, because we do not save the PB in the queue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to