yiguolei commented on code in PR #27822:
URL: https://github.com/apache/doris/pull/27822#discussion_r1410474728
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -412,21 +401,10 @@ struct StringFindOp : public BaseOp {
}
}
- static bool find(const BloomFilterAdaptor& bloom_filter, const void* data)
{
+ bool find_olap_engine(const BloomFilterAdaptor& bloom_filter, const void*
data) const override {
const auto* value = reinterpret_cast<const StringRef*>(data);
- if (value == nullptr) {
Review Comment:
why remove value == nullptr check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
