HappenLee commented on code in PR #27182:
URL: https://github.com/apache/doris/pull/27182#discussion_r1410095372
##########
be/src/olap/schema_change.cpp:
##########
@@ -1191,17 +1186,14 @@ Status SchemaChangeHandler::_parse_request(const
SchemaChangeParams& sc_params,
ColumnMapping* column_mapping = changer->get_mutable_column_mapping(i);
column_mapping->new_column = &new_column;
- if (materialized_function_map.find(column_name) !=
materialized_function_map.end()) {
- auto mvParam = materialized_function_map.find(column_name)->second;
- column_mapping->expr = mvParam.expr;
- int32_t column_index =
base_tablet_schema->field_index(mvParam.origin_column_name);
- if (column_index >= 0) {
- column_mapping->ref_column = column_index;
+ if (materialized_function_map.find(to_lower(column_name)) !=
Review Comment:
if need lower column name，only call once `to_lower` before the function
##########
be/src/olap/schema_change.cpp:
##########
@@ -1191,17 +1186,14 @@ Status SchemaChangeHandler::_parse_request(const
SchemaChangeParams& sc_params,
ColumnMapping* column_mapping = changer->get_mutable_column_mapping(i);
column_mapping->new_column = &new_column;
- if (materialized_function_map.find(column_name) !=
materialized_function_map.end()) {
- auto mvParam = materialized_function_map.find(column_name)->second;
- column_mapping->expr = mvParam.expr;
- int32_t column_index =
base_tablet_schema->field_index(mvParam.origin_column_name);
- if (column_index >= 0) {
- column_mapping->ref_column = column_index;
+ if (materialized_function_map.find(to_lower(column_name)) !=
Review Comment:
if need lower column name，only call once `to_lower` before the function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
