yiguolei commented on code in PR #27787:
URL: https://github.com/apache/doris/pull/27787#discussion_r1410067245
##########
be/src/common/exception.h:
##########
@@ -121,3 +121,6 @@ inline const std::string& Exception::to_string() const {
return Status::Error<false>(e.code(), e.to_string());
\
}
\
} while (0)
+
+#define THROW_ARITHMETIC_OVERFLOW_ERRROR \
+ throw Exception(ErrorCode::ARITHMETIC_OVERFLOW_ERRROR, "Arithmetic
overflow")
Review Comment:
this macro is not reasonable.
If we define such a macro, then we may need define many many macros... each
error code need a macro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
