github-actions[bot] commented on code in PR #27785:
URL: https://github.com/apache/doris/pull/27785#discussion_r1409650491
##########
be/src/olap/base_tablet.cpp:
##########
@@ -66,13 +67,17 @@ void BaseTablet::update_max_version_schema(const
TabletSchemaSPtr& tablet_schema
}
}
-void BaseTablet::update_by_least_common_schema(const TabletSchemaSPtr&
update_schema) {
+Status BaseTablet::update_by_least_common_schema(const TabletSchemaSPtr&
update_schema) {
Review Comment:
warning: method 'update_by_least_common_schema' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/base_tablet.h:67:
```diff
- Status update_by_least_common_schema(const TabletSchemaSPtr&
update_schema);
+ static Status update_by_least_common_schema(const TabletSchemaSPtr&
update_schema);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
