github-actions[bot] commented on code in PR #27779:
URL: https://github.com/apache/doris/pull/27779#discussion_r1409289209
##########
be/src/vec/columns/column_string.cpp:
##########
@@ -124,10 +124,10 @@ void ColumnString::insert_range_from(const IColumn& src,
size_t start, size_t le
}
}
-void ColumnString::insert_indices_from(const IColumn& src, const int*
indices_begin,
- const int* indices_end) {
- const ColumnString& src_str = assert_cast<const ColumnString&>(src);
- auto src_offset_data = src_str.offsets.data();
+void ColumnString::insert_indices_from(const IColumn& src, const uint32_t*
indices_begin,
Review Comment:
warning: method 'insert_indices_from' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_string.h:486:
```diff
- void insert_indices_from(const IColumn& src, const uint32_t*
indices_begin,
+ static void insert_indices_from(const IColumn& src, const uint32_t*
indices_begin,
```
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -225,23 +225,14 @@ void ColumnStruct::update_crcs_with_value(uint32_t*
__restrict hash, PrimitiveTy
}
}
-void ColumnStruct::insert_indices_from(const IColumn& src, const int*
indices_begin,
- const int* indices_end) {
- const ColumnStruct& src_concrete = assert_cast<const ColumnStruct&>(src);
+void ColumnStruct::insert_indices_from(const IColumn& src, const uint32_t*
indices_begin,
Review Comment:
warning: method 'insert_indices_from' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_struct.h:123:
```diff
- void insert_indices_from(const IColumn& src, const uint32_t*
indices_begin,
+ static void insert_indices_from(const IColumn& src, const uint32_t*
indices_begin,
```
##########
be/src/vec/core/block.cpp:
##########
@@ -950,7 +950,8 @@ void MutableBlock::add_row(const Block* block, int row) {
}
}
-void MutableBlock::add_rows(const Block* block, const int* row_begin, const
int* row_end) {
+void MutableBlock::add_rows(const Block* block, const uint32_t* row_begin,
Review Comment:
warning: method 'add_rows' can be made const
[readability-make-member-function-const]
be/src/vec/core/block.h:565:
```diff
- void add_rows(const Block* block, const uint32_t* row_begin, const
uint32_t* row_end);
+ void add_rows(const Block* block, const uint32_t* row_begin, const
uint32_t* row_end) const;
```
be/src/vec/core/block.cpp:953:
```diff
- const uint32_t* row_end) {
+ const uint32_t* row_end) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
