yiguolei commented on code in PR #27661:
URL: https://github.com/apache/doris/pull/27661#discussion_r1408615029
##########
be/src/util/arrow/row_batch.cpp:
##########
@@ -168,12 +168,13 @@ Status convert_to_arrow_schema(const RowDescriptor&
row_desc,
Status convert_expr_ctxs_arrow_schema(const vectorized::VExprContextSPtrs&
output_vexpr_ctxs,
std::shared_ptr<arrow::Schema>* result) {
std::vector<std::shared_ptr<arrow::Field>> fields;
- for (auto expr_ctx : output_vexpr_ctxs) {
+ for (int i = 0; i < output_vexpr_ctxs.size(); i++) {
Review Comment:
这里为什么要这么改呀？
##########
be/src/util/arrow/row_batch.cpp:
##########
@@ -168,12 +168,13 @@ Status convert_to_arrow_schema(const RowDescriptor&
row_desc,
Status convert_expr_ctxs_arrow_schema(const vectorized::VExprContextSPtrs&
output_vexpr_ctxs,
std::shared_ptr<arrow::Schema>* result) {
std::vector<std::shared_ptr<arrow::Field>> fields;
- for (auto expr_ctx : output_vexpr_ctxs) {
+ for (int i = 0; i < output_vexpr_ctxs.size(); i++) {
Review Comment:
这里为什么要这么改呀？
##########
be/src/common/config.cpp:
##########
@@ -61,6 +61,8 @@ DEFINE_Int32(brpc_port, "8060");
DEFINE_Int32(arrow_flight_sql_port, "-1");
+DEFINE_mString(arrow_flight_sql_host, "");
Review Comment:
这个代码，我们确定要合入吗？
##########
be/src/common/config.cpp:
##########
@@ -61,6 +61,8 @@ DEFINE_Int32(brpc_port, "8060");
DEFINE_Int32(arrow_flight_sql_port, "-1");
+DEFINE_mString(arrow_flight_sql_host, "");
Review Comment:
这个代码，我们确定要合入吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
