This is an automated email from the ASF dual-hosted git repository.

kxiao pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.0 by this push:
     new b43e28a99c6 [Bug](join) try fix wrong _has_null_in_build_side setted 
(#27684) (#27710)
b43e28a99c6 is described below

commit b43e28a99c62678b8f46da78457ae6b85419c50e
Author: Pxl <pxl...@qq.com>
AuthorDate: Tue Nov 28 22:04:17 2023 +0800

    [Bug](join) try fix wrong _has_null_in_build_side setted (#27684) (#27710)
---
 be/src/vec/exec/join/vhash_join_node.cpp | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/be/src/vec/exec/join/vhash_join_node.cpp 
b/be/src/vec/exec/join/vhash_join_node.cpp
index c8bf5c9b36d..5a92fc674cf 100644
--- a/be/src/vec/exec/join/vhash_join_node.cpp
+++ b/be/src/vec/exec/join/vhash_join_node.cpp
@@ -910,11 +910,6 @@ Status HashJoinNode::sink(doris::RuntimeState* state, 
vectorized::Block* in_bloc
     // make one block for each 4 gigabytes
     constexpr static auto BUILD_BLOCK_MAX_SIZE = 4 * 1024UL * 1024UL * 1024UL;
 
-    if (_has_null_in_build_side) {
-        // TODO: if _has_null_in_build_side is true we should finish current 
pipeline task.
-        DCHECK(state->enable_pipeline_exec());
-        return Status::OK();
-    }
     if (_should_build_hash_table) {
         // If eos or have already met a null value using short-circuit 
strategy, we do not need to pull
         // data from probe side.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to