github-actions[bot] commented on code in PR #26856:
URL: https://github.com/apache/doris/pull/26856#discussion_r1407061315
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -184,8 +186,10 @@ Status GroupCommitTable::_create_group_commit_load(
Status st = Status::OK();
std::unique_ptr<int, std::function<void(int*)>>
finish_plan_func((int*)0x01, [&](int*) {
if (!st.ok()) {
- std::unique_lock l(_lock);
- _need_plan_fragment = false;
+ {
+ std::unique_lock l(_lock);
+ _need_plan_fragment = false;
Review Comment:
warning: function '_create_group_commit_load' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status GroupCommitTable::_create_group_commit_load(
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/group_commit_mgr.cpp:190:** 90 lines including whitespace
and comments (threshold 80)
```cpp
Status GroupCommitTable::_create_group_commit_load(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
