github-actions[bot] commented on code in PR #27648:
URL: https://github.com/apache/doris/pull/27648#discussion_r1406058431
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1422,4 +1424,46 @@
return Status::OK();
}
+bool StorageEngine::_increase_low_priority_task_nums(DataDir* dir) {
+ if (config::enable_compaction_priority_scheduling) {
+ std::lock_guard l(_low_priority_task_nums_mutex);
+ if (_low_priority_task_nums[dir] <
config::low_priority_compaction_task_num_per_disk) {
+ _low_priority_task_nums[dir]++;
+ return true;
+ }
+ }
+ return false;
+}
+
+void StorageEngine::_decrease_low_priority_task_nums(DataDir* dir) {
Review Comment:
warning: method '_decrease_low_priority_task_nums' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/storage_engine.h:341:
```diff
- void _decrease_low_priority_task_nums(DataDir* dir);
+ static void _decrease_low_priority_task_nums(DataDir* dir);
```
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1422,4 +1424,46 @@ Status StorageEngine::_persist_broken_paths() {
return Status::OK();
}
+bool StorageEngine::_increase_low_priority_task_nums(DataDir* dir) {
Review Comment:
warning: method '_increase_low_priority_task_nums' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/storage_engine.h:339:
```diff
- bool _increase_low_priority_task_nums(DataDir* dir);
+ static bool _increase_low_priority_task_nums(DataDir* dir);
```
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1422,4 +1424,46 @@
return Status::OK();
}
+bool StorageEngine::_increase_low_priority_task_nums(DataDir* dir) {
+ if (config::enable_compaction_priority_scheduling) {
+ std::lock_guard l(_low_priority_task_nums_mutex);
+ if (_low_priority_task_nums[dir] <
config::low_priority_compaction_task_num_per_disk) {
+ _low_priority_task_nums[dir]++;
+ return true;
+ }
+ }
+ return false;
+}
+
+void StorageEngine::_decrease_low_priority_task_nums(DataDir* dir) {
+ if (config::enable_compaction_priority_scheduling) {
+ std::lock_guard l(_low_priority_task_nums_mutex);
+ _low_priority_task_nums[dir]--;
+ DCHECK(_low_priority_task_nums[dir] >= 0);
+ }
+}
+
+bool StorageEngine::_is_low_priority_task(TabletSharedPtr tablet,
CompactionType compaction_type,
Review Comment:
warning: method '_is_low_priority_task' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/storage_engine.cpp:1447:
```diff
- bool force) const {
+ bool force) {
```
be/src/olap/storage_engine.h:343:
```diff
- bool _is_low_priority_task(TabletSharedPtr tablet, CompactionType
compaction_type,
- bool force) const;
+ static bool _is_low_priority_task(TabletSharedPtr tablet,
CompactionType compaction_type,
+ bool force) ;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
