github-actions[bot] commented on code in PR #27623:
URL: https://github.com/apache/doris/pull/27623#discussion_r1405751176
##########
be/src/vec/aggregate_functions/aggregate_function_window.cpp:
##########
@@ -32,17 +32,32 @@
namespace doris::vectorized {
template <template <typename> class AggregateFunctionTemplate,
- template <typename ColVecType, bool, bool> class Data, template
<typename> class Impl,
- bool result_is_nullable, bool arg_is_nullable>
+ template <typename ColVecType, bool, bool> class Data,
+ template <typename, bool> class Impl, bool result_is_nullable, bool
arg_is_nullable>
AggregateFunctionPtr create_function_lead_lag_first_last(const String& name,
Review Comment:
warning: function 'create_function_lead_lag_first_last' has cognitive
complexity of 110 (threshold 50) [readability-function-cognitive-complexity]
```cpp
AggregateFunctionPtr create_function_lead_lag_first_last(const String& name,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:42:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (argument_types.size() == 2) {
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:43:** +1
```cpp
DCHECK(name == "first_value" || name == "last_value") << "invalid
function name: " << name;
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
**be/src/vec/aggregate_functions/aggregate_function_window.cpp:60:** +1,
nesting level increased to 2
```cpp
TYPE_TO_COLUMN_TYPE(DISPATCH)
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
