github-actions[bot] commented on code in PR #27591:
URL: https://github.com/apache/doris/pull/27591#discussion_r1405547749
##########
be/src/olap/task/engine_clone_task.cpp:
##########
@@ -577,8 +575,8 @@ Status EngineCloneTask::_download_files(DataDir* data_dir,
const std::string& re
/// This method will do the following things:
/// 1. Linke all files from CLONE dir to tablet dir if file does not exist in
tablet dir
/// 2. Call _finish_xx_clone() to revise the tablet meta.
-Status EngineCloneTask::_finish_clone(Tablet* tablet, const std::string&
clone_dir,
- int64_t committed_version, bool
is_incremental_clone) {
+Status EngineCloneTask::_finish_clone(Tablet* tablet, const std::string&
clone_dir, int64_t version,
Review Comment:
warning: function '_finish_clone' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
.
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/task/engine_clone_task.cpp:577:** 140 lines including
whitespace and comments (threshold 80)
```cpp
.
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
