github-actions[bot] commented on code in PR #26709:
URL: https://github.com/apache/doris/pull/26709#discussion_r1405301762
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -112,6 +119,52 @@ void DataTypeDateTimeV2SerDe::write_column_to_arrow(const
IColumn& column, const
}
}
+void DataTypeDateTimeV2SerDe::read_column_from_arrow(IColumn& column,
Review Comment:
warning: method 'read_column_from_arrow' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void DataTypeDateTimeV2SerDe::read_column_from_arrow(IColumn& column,
```
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:123:
```diff
- int end, const
cctz::time_zone& ctz) const {
+ int end, const
cctz::time_zone& ctz) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
