github-actions[bot] commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1405139431
##########
be/src/olap/reader.cpp:
##########
@@ -680,4 +687,19 @@ Status TabletReader::init_reader_params_and_create_block(
return Status::OK();
}
+Status TabletReader::push_late_arrival_runtime_filter(const IRuntimeFilter*
filter,
Review Comment:
warning: method 'push_late_arrival_runtime_filter' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/reader.h:226:
```diff
- Status push_late_arrival_runtime_filter(const IRuntimeFilter* filter,
+ static Status push_late_arrival_runtime_filter(const IRuntimeFilter*
filter,
```
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1951,6 +1977,124 @@ Status
SegmentIterator::_read_columns_by_rowids(std::vector<ColumnId>& read_colu
return Status::OK();
}
+Status SegmentIterator::_process_late_arrival_predicates(
Review Comment:
warning: function '_process_late_arrival_predicates' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status SegmentIterator::_process_late_arrival_predicates(
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/segment_iterator.cpp:1979:** 93 lines
including whitespace and comments (threshold 80)
```cpp
Status SegmentIterator::_process_late_arrival_predicates(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
