github-actions[bot] commented on code in PR #27561: URL: https://github.com/apache/doris/pull/27561#discussion_r1404282855
########## be/src/vec/sink/writer/vtablet_writer_v2.cpp: ########## @@ -274,13 +274,17 @@ Status VTabletWriterV2::_open_streams_to_backend(int64_t dst_id, return Status::OK(); } -void VTabletWriterV2::_build_tablet_node_mapping() { +Status VTabletWriterV2::_build_tablet_node_mapping() { Review Comment: warning: method '_build_tablet_node_mapping' can be made static [readability-convert-member-functions-to-static] be/src/vec/sink/writer/vtablet_writer_v2.h:134: ```diff - Status _build_tablet_node_mapping(); + static Status _build_tablet_node_mapping(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org