github-actions[bot] commented on code in PR #27542:
URL: https://github.com/apache/doris/pull/27542#discussion_r1404034203
##########
be/src/util/block_compression.cpp:
##########
@@ -1006,6 +1011,39 @@ class GzipBlockCompression final : public
ZlibBlockCompression {
const static int MEM_LEVEL = 8;
};
+// Only used on x86 or x86_64
+#if defined(__x86_64__) || defined(_M_X64) || defined(i386) ||
defined(__i386__) || \
+ defined(__i386) || defined(_M_IX86)
+class GzipBlockCompressionByLibdeflate final : public GzipBlockCompression {
+public:
+ GzipBlockCompressionByLibdeflate() : GzipBlockCompression() {}
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
GzipBlockCompressionByLibdeflate() : GzipBlockCompression() = default;
```
##########
be/src/util/block_compression.cpp:
##########
@@ -1006,6 +1011,39 @@
const static int MEM_LEVEL = 8;
};
+// Only used on x86 or x86_64
+#if defined(__x86_64__) || defined(_M_X64) || defined(i386) ||
defined(__i386__) || \
+ defined(__i386) || defined(_M_IX86)
+class GzipBlockCompressionByLibdeflate final : public GzipBlockCompression {
+public:
+ GzipBlockCompressionByLibdeflate() : GzipBlockCompression() {}
+ static GzipBlockCompressionByLibdeflate* instance() {
+ static GzipBlockCompressionByLibdeflate s_instance;
+ return &s_instance;
+ }
+ ~GzipBlockCompressionByLibdeflate() override = default;
+
+ Status decompress(const Slice& input, Slice* output) override {
Review Comment:
warning: method 'decompress' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status decompress(const Slice& input, Slice* output) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
