morrySnow commented on code in PR #27403:
URL: https://github.com/apache/doris/pull/27403#discussion_r1401849906


##########
fe/fe-core/src/main/java/org/apache/doris/common/util/LiteralUtils.java:
##########
@@ -32,7 +32,9 @@
 public class LiteralUtils {
 
     public static String getStringValue(FloatLiteral literal) {
-        if (literal.getType() == Type.TIME || literal.getType() == 
Type.TIMEV2) {
+        if (Double.isNaN(literal.getValue())) {
+            return "nan";

Review Comment:
   we should not return nan. and this is not a right way to fix this problem. 
in sql, we could only return valid value of the type of this column or Null 
literal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to