Gabriel39 commented on code in PR #27348:
URL: https://github.com/apache/doris/pull/27348#discussion_r1401821134
##########
be/src/pipeline/exec/union_source_operator.h:
##########
@@ -79,13 +79,8 @@ class UnionSourceDependency final : public Dependency {
if (((UnionSharedState*)_shared_state.get())->child_count() == 0) {
return nullptr;
}
- if
(((UnionSharedState*)_shared_state.get())->data_queue.is_all_finish() ||
-
((UnionSharedState*)_shared_state.get())->data_queue.remaining_has_data()) {
- return nullptr;
- }
- return this;
+ return Dependency::is_blocked_by(task);
Review Comment:
Not to implement `is_blocked_by`
##########
be/src/pipeline/exec/data_queue.h:
##########
@@ -62,7 +62,13 @@ class DataQueue {
bool data_exhausted() const { return _data_exhausted; }
void set_dependency(Dependency* source_dependency, Dependency*
sink_dependency) {
Review Comment:
delete this function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
