Tanya-W commented on code in PR #27276:
URL: https://github.com/apache/doris/pull/27276#discussion_r1401545516
##########
be/src/olap/task/index_builder.cpp:
##########
@@ -198,6 +198,11 @@ Status
IndexBuilder::handle_single_rowset(RowsetMetaSharedPtr output_rowset_meta
}
}
+ if (return_columns.empty()) {
+ // no columns to read
+ break;
Review Comment:
return_columns is build by _alter_inverted_indexes, so the behavior of all
segments is consistent, so here can be directly break
##########
be/src/olap/task/index_builder.cpp:
##########
@@ -280,6 +278,11 @@ Status
IndexBuilder::_write_inverted_index_data(TabletSchemaSPtr tablet_schema,
auto column = tablet_schema->column(column_idx);
auto writer_sign = std::make_pair(segment_idx, index_id);
std::unique_ptr<Field> field(FieldFactory::create(column));
+ auto converted_result = _olap_data_convertor->convert_column_data(i);
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
