CalvinKirs commented on code in PR #26146:
URL: https://github.com/apache/doris/pull/26146#discussion_r1400312656
##########
fe/fe-core/src/main/java/org/apache/doris/job/task/AbstractTask.java:
##########
@@ -21,39 +21,45 @@
import org.apache.doris.job.base.Job;
import org.apache.doris.job.common.TaskStatus;
import org.apache.doris.job.common.TaskType;
+import org.apache.doris.job.exception.JobException;
+import com.google.gson.annotations.SerializedName;
import lombok.Data;
import lombok.extern.slf4j.Slf4j;
@Data
@Slf4j
public abstract class AbstractTask implements Task {
+ @SerializedName(value = "jid")
private Long jobId;
-
+ @SerializedName(value = "tid")
private Long taskId;
+ @SerializedName(value = "st")
private TaskStatus status;
-
+ @SerializedName(value = "ctm")
private Long createTimeMs;
-
+ @SerializedName(value = "stm")
private Long startTimeMs;
-
+ @SerializedName(value = "ftm")
private Long finishTimeMs;
+ @SerializedName(value = "tt")
private TaskType taskType;
@Override
public void onFail(String msg) {
+ status = TaskStatus.FAILD;
if (!isCallable()) {
return;
}
Env.getCurrentEnv().getJobManager().getJob(jobId).onTaskFail(this);
- status = TaskStatus.FAILD;
}
@Override
- public void onFail() {
+ public void onFail() throws JobException {
+ status = TaskStatus.FAILD;
Review Comment:
Good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
