csun5285 commented on code in PR #27299:
URL: https://github.com/apache/doris/pull/27299#discussion_r1399977694
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -70,6 +70,12 @@ uint32_t
TimeSeriesCumulativeCompactionPolicy::calc_cumulative_compaction_score(
return score;
}
+ // If their are many empty rowset, maybe should be compact
+ auto consecutive_empty_rowsets =
tablet->collect_consecutive_empty_rowsets();
Review Comment:
done
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -229,6 +242,14 @@ int
TimeSeriesCumulativeCompactionPolicy::pick_input_rowsets(
return transient_size;
}
+ auto consecutive_empty_rowsets =
tablet->collect_consecutive_empty_rowsets();
Review Comment:
done
##########
be/src/olap/tablet.h:
##########
@@ -272,6 +272,8 @@ class Tablet final : public BaseTablet {
std::vector<RowsetSharedPtr>
pick_candidate_rowsets_to_single_replica_compaction();
std::vector<Version> get_all_versions();
+ std::vector<RowsetSharedPtr> collect_consecutive_empty_rowsets();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
