yiguolei commented on code in PR #27202:
URL: https://github.com/apache/doris/pull/27202#discussion_r1398704147
##########
be/src/olap/rowset/segment_v2/inverted_index_compound_directory.cpp:
##########
@@ -392,10 +393,19 @@ DorisCompoundDirectory::FSIndexOutput::~FSIndexOutput() {
if (writer) {
try {
FSIndexOutput::close();
+ DBUG_EXECUTE_IF(
+
"DorisCompoundDirectory::FSIndexOutput._throw_clucene_error_in_fsindexoutput_"
+ "destructor",
+ {
+ _CLTHROWA(CL_ERR_IO,
+ "debug point: test throw error in
fsindexoutput destructor");
+ })
} catch (CLuceneError& err) {
//ignore errors...
+ writer.reset(nullptr);
Review Comment:
If writer is a member of the Class. Then rename it to _writer OR writer_.
And why do you need reset here? since the unique ptr will decontructed
automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
