morningman commented on a change in pull request #5436:
URL: https://github.com/apache/incubator-doris/pull/5436#discussion_r592403731
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/DateLiteral.java
##########
@@ -144,6 +144,8 @@
//Regex used to determine if the TIME field exists int date_format
private static final Pattern HAS_TIME_PART =
Pattern.compile("^.*[HhIiklrSsTp]+.*$");
+ // max length of datetime string
+ int MAX_DATETIME_VALUE_LENGTH = new String("yyyy-MM-dd hh:mm:ss").length();
Review comment:
missing `private static final`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
