github-actions[bot] commented on code in PR #27145:
URL: https://github.com/apache/doris/pull/27145#discussion_r1397406580
##########
be/src/vec/exec/format/json/new_json_reader.h:
##########
@@ -137,7 +137,8 @@ class NewJsonReader : public GenericReader {
static std::string _print_json_value(const rapidjson::Value& value);
- Status _read_one_message(std::unique_ptr<uint8_t[]>* file_buf, size_t*
read_size);
+ Status _read_one_message(std::unique_ptr<uint8_t[]>* file_buf, size_t*
read_size,
+ size_t* total_length = 0);
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
size_t* total_length = nullptr);
```
##########
be/src/io/fs/stream_load_pipe.h:
##########
@@ -74,7 +74,8 @@ class StreamLoadPipe : public MessageBodySink, public
FileReader {
// called when producer/consumer failed
virtual void cancel(const std::string& reason) override;
- Status read_one_message(std::unique_ptr<uint8_t[]>* data, size_t* length);
+ Status read_one_message(std::unique_ptr<uint8_t[]>* data, size_t* length,
+ size_t* total_length = 0);
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
size_t* total_length = nullptr);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
