XieJiann commented on code in PR #27051: URL: https://github.com/apache/doris/pull/27051#discussion_r1396731837
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/BlockFD.java: ########## @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans; + +import org.apache.doris.nereids.properties.FunctionalDependencies; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.plans.logical.LogicalPlan; + +import java.util.List; + +/** + * Block fd + */ +public interface BlockFD extends LogicalPlan { + @Override + default FunctionalDependencies computeFD(List<Slot> outputs) { + return new FunctionalDependencies(); Review Comment: 最好不要隐式作为默认的方法，这样之后新写一个plan会忽略到底需不需要传递。现在只是implement 一个借口，也比较好写 ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/BlockFD.java: ########## @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans; + +import org.apache.doris.nereids.properties.FunctionalDependencies; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.plans.logical.LogicalPlan; + +import java.util.List; + +/** + * Block fd + */ +public interface BlockFD extends LogicalPlan { + @Override + default FunctionalDependencies computeFD(List<Slot> outputs) { + return new FunctionalDependencies(); Review Comment: 最好不要隐式作为默认的方法，这样之后新写一个plan会忽略到底需不需要传递。现在只是implement 一个借口，也比较好写 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
