github-actions[bot] commented on code in PR #26879: URL: https://github.com/apache/doris/pull/26879#discussion_r1396620931
########## be/src/pipeline/pipeline_task.h: ########## @@ -251,6 +257,26 @@ class PipelineTask { void set_parent_profile(RuntimeProfile* profile) { _parent_profile = profile; } + virtual bool is_pipelineX() const { return false; } + + void set_blocked(bool blocked) { + std::unique_lock<std::mutex> lc(_blocked_lock); + if (blocked) { + DCHECK(!_blocked) << debug_string(); + } else { + _wake_stack_msg = get_stack_trace(); + DCHECK(_blocked) << debug_string(); + } + _blocked = blocked; + } + Review Comment: warning: method 'is_blocked' can be made const [readability-make-member-function-const] ```suggestion bool is_blocked() const { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org