github-actions[bot] commented on code in PR #26915: URL: https://github.com/apache/doris/pull/26915#discussion_r1395121331
########## be/src/vec/core/block.cpp: ########## @@ -965,6 +966,22 @@ void MutableBlock::add_rows(const Block* block, size_t row_begin, size_t length) } } +void MutableBlock::add_rows(const Block* block, std::vector<int64_t> rows) { Review Comment: warning: method 'add_rows' can be made const [readability-make-member-function-const] ```suggestion void MutableBlock::add_rows(const Block* block, std::vector<int64_t> rows) const { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org