github-actions[bot] commented on code in PR #27067: URL: https://github.com/apache/doris/pull/27067#discussion_r1395111338
########## be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp: ########## @@ -1005,4 +1010,23 @@ Status PipelineXFragmentContext::send_report(bool done) { std::placeholders::_2)}, shared_from_this()); } + +bool PipelineXFragmentContext::_has_inverted_index_or_partial_update(TOlapTableSink sink) { Review Comment: warning: method '_has_inverted_index_or_partial_update' can be made static [readability-convert-member-functions-to-static] be/src/pipeline/pipeline_x/pipeline_x_fragment_context.h:148: ```diff - bool _has_inverted_index_or_partial_update(TOlapTableSink sink); + static bool _has_inverted_index_or_partial_update(TOlapTableSink sink); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org