github-actions[bot] commented on code in PR #26879:
URL: https://github.com/apache/doris/pull/26879#discussion_r1394142218
##########
be/src/pipeline/pipeline_x/dependency.cpp:
##########
@@ -294,6 +451,12 @@ std::vector<uint16_t>
HashJoinDependency::convert_block_to_null(vectorized::Bloc
return results;
}
+void SetSharedState::set_probe_finished_children(int child_id) {
+ if (child_id + 1 < probe_finished_children_dependency.size()) {
+ probe_finished_children_dependency[child_id +
1]->set_ready_for_write();
Review Comment:
warning: method 'set_probe_finished_children' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/dependency.h:785:
```diff
- void set_probe_finished_children(int child_id);
+ static void set_probe_finished_children(int child_id);
```
##########
be/src/pipeline/pipeline_x/dependency.cpp:
##########
@@ -433,9 +596,19 @@
}
void RuntimeFilterDependency::sub_filters() {
- _filters--;
- if (_filters == 0) {
- *_blocked_by_rf = false;
+ auto value = _filters.fetch_sub(1);
+ if (value == 1) {
Review Comment:
warning: method 'sub_filters' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/dependency.h:258:
```diff
- void sub_filters();
+ static void sub_filters();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
