eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1393629717
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -483,5 +649,25 @@ Status Segment::read_key_by_rowid(uint32_t row_id,
std::string* key) {
return Status::OK();
}
+bool Segment::same_with_storage_type(int32_t cid, const Schema& schema,
+ bool ignore_children) const {
+ auto file_column_type = get_data_type_of(*schema.column(cid),
ignore_children);
+ auto expected_type = Schema::get_data_type_ptr(*schema.column(cid));
+ // ignore struct and map now
+ auto type_without_nullable = vectorized::remove_nullable(expected_type);
+ if (vectorized::WhichDataType(type_without_nullable).is_struct() ||
+ vectorized::WhichDataType(type_without_nullable).is_map()) {
+ return true;
Review Comment:
useless code, deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
