yujun777 commented on code in PR #26712:
URL: https://github.com/apache/doris/pull/26712#discussion_r1388016993


##########
be/src/olap/task/engine_publish_version_task.cpp:
##########
@@ -91,6 +92,17 @@ Status EnginePublishVersionTask::finish() {
     int64_t transaction_id = _publish_version_req.transaction_id;
     OlapStopWatch watch;
     VLOG_NOTICE << "begin to process publish version. transaction_id=" << 
transaction_id;
+    DBUG_EXECUTE_IF("EnginePublishVersionTask.finish", {

Review Comment:
   failed and wait are two action,  need two debug points. seperate them



##########
fe/fe-core/src/main/java/org/apache/doris/alter/AlterJobV2.java:
##########
@@ -155,6 +157,19 @@ public void setFinishedTimeMs(long finishedTimeMs) {
         this.finishedTimeMs = finishedTimeMs;
     }
 
+    // /api/debug_point/add/{name}?value=100
+    private void stateWait(final String name) {
+        long waitTimeMs = DebugPointUtil.isEnable(name) ? 
DebugPointUtil.getDebugParamOrDefault(name, 0) : 0;

Review Comment:
   long waitTimeMs = DebugPointUtil.getDebugParamOrDefault(name, 0)



##########
fe/fe-core/src/main/java/org/apache/doris/alter/AlterJobV2.java:
##########
@@ -171,15 +186,28 @@ public synchronized void run() {
             return;
         }
 
+        // /api/debug_point/add/FE.ALTER_JOB_V2_RUN?stop=true
+        if (DebugPointUtil.isEnable("FE.ALTER_JOB_V2_RUN")) {

Review Comment:
   boolean stop = DebugPointUtil.getDebugParamOrDefault(FE.ALTER_JOB_V2_RUN, 
"stop", false)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to