xinghuayu007 commented on a change in pull request #5444: URL: https://github.com/apache/incubator-doris/pull/5444#discussion_r586211595
########## File path: fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteFromUnixTimeRule.java ########## @@ -0,0 +1,107 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.rewrite; + +import org.apache.doris.analysis.Analyzer; +import org.apache.doris.analysis.BinaryPredicate; +import org.apache.doris.analysis.BoolLiteral; +import org.apache.doris.analysis.CompoundPredicate; +import org.apache.doris.analysis.Expr; +import org.apache.doris.analysis.FunctionCallExpr; +import org.apache.doris.analysis.FunctionParams; +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.analysis.SlotRef; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.AnalysisException; + +import java.text.ParseException; +import java.text.SimpleDateFormat; +import java.util.Date; + +/* +* rewrite sql: select * from table where from_unixtime(query_time) > '2021-03-02 12:12:23' +* into: select * from table where query_time > 1614658343 +* query_time is integer type +* 1614658343 is the timestamp of 2021-03-02 12:12:23 +* this rewrite can improve the query performance, because from_unixtime is cpu-exhausted +* */ +public class RewriteFromUnixTimeRule implements ExprRewriteRule { + public static RewriteFromUnixTimeRule INSTANCE = new RewriteFromUnixTimeRule(); + @Override + public Expr apply(Expr expr, Analyzer analyzer) throws AnalysisException { + if (!(expr instanceof BinaryPredicate)) { + return expr; + } + BinaryPredicate bp = (BinaryPredicate) expr; + Expr left = bp.getChild(0); + if (!(left instanceof FunctionCallExpr)) { + return expr; + } + FunctionCallExpr fce = (FunctionCallExpr) left; + if (!fce.getFnName().getFunction().equalsIgnoreCase("from_unixtime")) { + return expr; + } + FunctionParams params = fce.getParams(); + if (params == null) { + return expr; + } + //definition: from_unixtime(int, format) + if (params.exprs().size() != 1 && params.exprs().size() != 2) { + return expr; + } + Expr paramSlot = params.exprs().get(0); + if (!(paramSlot instanceof SlotRef)) { + return expr; + } + SlotRef sr = (SlotRef) paramSlot; + if (!sr.getColumn().getType().isIntegerType()) { + return new BoolLiteral(false); + } + Expr right = bp.getChild(1); + if (!(right instanceof LiteralExpr)) { + return expr; + } + LiteralExpr le = (LiteralExpr) right; + SimpleDateFormat format = new SimpleDateFormat( "yyyy-MM-dd" ); + //default format is "yyyy-MM-dd HH:mm:ss" + if (params.exprs().size() == 1) { + format = new SimpleDateFormat( "yyyy-MM-dd HH:mm:ss" ); + } else { + LiteralExpr fm = (LiteralExpr) params.exprs().get(1); + format = new SimpleDateFormat(fm.getStringValue()); + } + try { + Date date = format.parse(le.getStringValue()); + //it is better to add low bound 0, because when a field contains negative data like -100, it will be queried as a result Review comment: ok ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
