seawinde commented on code in PR #26592: URL: https://github.com/apache/doris/pull/26592#discussion_r1392069672
########## fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/HyperGraph.java: ########## @@ -304,6 +304,76 @@ private long calNodeMap(Set<Slot> slots) { return bitmap; } + public static HyperGraph from(Plan plan) { + Preconditions.checkArgument(plan.getGroupExpression().isPresent(), Review Comment: Should support plan without group. May be inside the methed from(Plan plan), call the memo.init(), and then build graph -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org