github-actions[bot] commented on code in PR #26897:
URL: https://github.com/apache/doris/pull/26897#discussion_r1391375487
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
- auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
- auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5, 1);
Review Comment:
warning: 5 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams1 = pool.get_or_create(load_id, src_id, 101, 5, 1);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
- auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
- auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5, 1);
+ auto streams2 = pool.get_or_create(load_id, src_id, 102, 5, 1);
+ auto streams3 = pool.get_or_create(load_id, src_id, 101, 5, 1);
Review Comment:
warning: 101 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams3 = pool.get_or_create(load_id, src_id, 101, 5, 1);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
- auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
- auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5, 1);
+ auto streams2 = pool.get_or_create(load_id, src_id, 102, 5, 1);
Review Comment:
warning: 5 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams2 = pool.get_or_create(load_id, src_id, 102, 5, 1);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@ TEST_F(LoadStreamStubPoolTest, test) {
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
- auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
- auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5, 1);
Review Comment:
warning: 101 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams1 = pool.get_or_create(load_id, src_id, 101, 5, 1);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
- auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
- auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5, 1);
+ auto streams2 = pool.get_or_create(load_id, src_id, 102, 5, 1);
Review Comment:
warning: 102 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams2 = pool.get_or_create(load_id, src_id, 102, 5, 1);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
- auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
- auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5, 1);
+ auto streams2 = pool.get_or_create(load_id, src_id, 102, 5, 1);
+ auto streams3 = pool.get_or_create(load_id, src_id, 101, 5, 1);
Review Comment:
warning: 5 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams3 = pool.get_or_create(load_id, src_id, 101, 5, 1);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
