airborne12 commented on code in PR #26689:
URL: https://github.com/apache/doris/pull/26689#discussion_r1390221566
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -189,9 +193,38 @@ class SegmentIterator::BackwardBitmapRangeIterator :
public SegmentIterator::Bit
return true;
}
+ uint32_t read_batch_rowids(rowid_t* buf, uint32_t batch_size) override {
+ if (!_riter.has_value || _rowid_left == 0) {
+ return 0;
+ }
+
+ if (_rowid_count <= batch_size) {
Review Comment:
No, here we are making a one-time determination of whether the size of the
roaring bitmap is smaller than the batch_size, rather than judging the
remaining size through '_rowid_left'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
