github-actions[bot] commented on code in PR #26686:
URL: https://github.com/apache/doris/pull/26686#discussion_r1387807103
##########
be/src/vec/data_types/serde/data_type_bitmap_serde.cpp:
##########
@@ -52,6 +52,26 @@ Status
DataTypeBitMapSerDe::deserialize_one_cell_from_json(IColumn& column, Slic
return Status::OK();
}
+void DataTypeBitMapSerDe::write_column_to_arrow(const IColumn& column, const
NullMap* null_map,
Review Comment:
warning: method 'write_column_to_arrow' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void DataTypeBitMapSerDe::write_column_to_arrow(const IColumn&
column, const NullMap* null_map,
```
be/src/vec/data_types/serde/data_type_bitmap_serde.cpp:56:
```diff
- int end) const {
+ int end) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
