BePPPower commented on code in PR #26656:
URL: https://github.com/apache/doris/pull/26656#discussion_r1387791026
##########
regression-test/suites/external_table_p0/jdbc/test_sqlserver_jdbc_catalog.groovy:
##########
@@ -71,7 +71,10 @@ suite("test_sqlserver_jdbc_catalog",
"p0,external,sqlserver,external_docker,exte
order_qt_filter2 """ select * from test_char where 1 = 1 and id = 1
order by id; """
order_qt_filter3 """ select * from test_char where id = 1 order by
id; """
order_qt_id """ select count(*) from (select * from t_id) as a; """
-
+ order_qt_all_type """ select * from all_type order by id; """
+ sql """ drop table if exists internal.${internal_db_name}.all_type; """
+ order_qt_ctas """ create table
internal.${internal_db_name}.ctas_all_type PROPERTIES("replication_num" = "1")
as select * from all_type; """
Review Comment:
we'd better add desc table test for table which is created by CTAS
##########
regression-test/suites/external_table_p0/jdbc/test_doris_jdbc_catalog.groovy:
##########
@@ -167,6 +171,12 @@ suite("test_doris_jdbc_catalog",
"p0,external,doris,external_docker,external_doc
order_qt_tb2 """ select pin_id, hll_union_agg(user_log_acct) from
${catalog_name}.${internal_db_name}.${hllTable} group by pin_id; """
order_qt_base2 """ select * from
${catalog_name}.${internal_db_name}.${base_table} order by int_col; """
order_qt_arr2 """ select * from
${catalog_name}.${internal_db_name}.${arr_table} order by int_col; """
+ sql """ drop table if exists internal.${internal_db_name}.ctas_base; """
+ sql """ drop table if exists internal.${internal_db_name}.ctas_arr; """
+ order_qt_ctas_base """ create table internal.${internal_db_name}.ctas_base
PROPERTIES("replication_num" = "1") as select * from
${catalog_name}.${internal_db_name}.${base_table} order by int_col; """
Review Comment:
we'd better add `desc table` test for table which is created by CTAS, to
ensure the type mapping is correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
