github-actions[bot] commented on code in PR #25921:
URL: https://github.com/apache/doris/pull/25921#discussion_r1387618793
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1247,8 +1242,14 @@ Status StorageEngine::execute_task(EngineTask* task) {
// check whether any unused rowsets's id equal to rowset_id
bool StorageEngine::check_rowset_id_in_unused_rowsets(const RowsetId&
rowset_id) {
std::lock_guard<std::mutex> lock(_gc_mutex);
- auto search = _unused_rowsets.find(rowset_id.to_string());
- return search != _unused_rowsets.end();
+ return _unused_rowsets.contains(rowset_id);
+}
+
+PendingRowsetGuard StorageEngine::add_pending_rowset(const
RowsetWriterContext& ctx) {
Review Comment:
warning: method 'add_pending_rowset' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/storage_engine.h:155:
```diff
- PendingRowsetGuard add_pending_rowset(const RowsetWriterContext& ctx);
+ static PendingRowsetGuard add_pending_rowset(const
RowsetWriterContext& ctx);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
