zhannngchen commented on code in PR #26632:
URL: https://github.com/apache/doris/pull/26632#discussion_r1387606249
##########
be/src/olap/tablet.h:
##########
@@ -438,7 +438,8 @@ class Tablet final : public BaseTablet {
const TabletColumn& tablet_column,
vectorized::MutableColumnPtr& dst);
- Status fetch_value_through_row_column(RowsetSharedPtr input_rowset,
uint32_t segid,
+ Status fetch_value_through_row_column(RowsetSharedPtr input_rowset,
Review Comment:
Add comments on this methods to explain some critical parameters, emphasize
that `cids` should be consistent with `tablet_schema`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
