github-actions[bot] commented on code in PR #26647:
URL: https://github.com/apache/doris/pull/26647#discussion_r1387584383
##########
be/src/vec/columns/column_map.cpp:
##########
@@ -433,14 +433,24 @@ ColumnPtr ColumnMap::replicate(const Offsets& offsets)
const {
return res;
}
-void ColumnMap::replicate(const uint32_t* indexs, size_t target_size, IColumn&
column) const {
+void ColumnMap::replicate(const uint32_t* indices, size_t target_size,
IColumn& column) const {
Review Comment:
warning: method 'replicate' can be made static
[readability-convert-member-functions-to-static]
```suggestion
void ColumnMap::replicate(const uint32_t* indices, size_t target_size,
IColumn& column) {
```
be/src/vec/columns/column_map.h:117:
```diff
- void replicate(const uint32_t* indexs, size_t target_size, IColumn&
column) const override;
+ static void replicate(const uint32_t* indexs, size_t target_size,
IColumn& column) override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
