[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #5344: [Compaction] Cache compaction score for tablet to avoid calculating each tablet score in every production

[GitBox]

acelyc111 commented on a change in pull request #5344:
URL: https://github.com/apache/incubator-doris/pull/5344#discussion_r571037899



##########
File path: be/src/olap/compaction.cpp
##########
@@ -127,8 +127,11 @@ OLAPStatus Compaction::do_compaction_impl(int64_t permits) 
{
     int64_t now = UnixMillis();
     if (compaction_type() == ReaderType::READER_CUMULATIVE_COMPACTION) {
         _tablet->set_last_cumu_compaction_success_time(now);
+        
_tablet->update_cumulative_compaction_score(_tablet->calc_compaction_score(CompactionType::CUMULATIVE_COMPACTION));

Review comment:
       I found every call of  `update_cumulative_compaction_score()` 's 
parameter is `calc_compaction_score()`, what's reason to do this?

##########
File path: be/src/olap/compaction.cpp
##########
@@ -127,8 +127,11 @@ OLAPStatus Compaction::do_compaction_impl(int64_t permits) 
{
     int64_t now = UnixMillis();
     if (compaction_type() == ReaderType::READER_CUMULATIVE_COMPACTION) {
         _tablet->set_last_cumu_compaction_success_time(now);
+        
_tablet->update_cumulative_compaction_score(_tablet->calc_compaction_score(CompactionType::CUMULATIVE_COMPACTION));

Review comment:
       I found every call of  `update_cumulative_compaction_score()` 's 
parameter is `calc_compaction_score()`, what's reason to do this?

##########
File path: be/src/olap/compaction.cpp
##########
@@ -127,8 +127,11 @@ OLAPStatus Compaction::do_compaction_impl(int64_t permits) 
{
     int64_t now = UnixMillis();
     if (compaction_type() == ReaderType::READER_CUMULATIVE_COMPACTION) {
         _tablet->set_last_cumu_compaction_success_time(now);
+        
_tablet->update_cumulative_compaction_score(_tablet->calc_compaction_score(CompactionType::CUMULATIVE_COMPACTION));

Review comment:
       I found every call of  `update_cumulative_compaction_score()` 's 
parameter is `calc_compaction_score()`, what's reason to do this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org